perf: speedup date_part isodow by using DayOfWeekMonday1#23491
Queued
theirix wants to merge 2 commits into
Queued
Conversation
nuno-faria
approved these changes
Jul 13, 2026
nuno-faria
left a comment
nuno-faria
left a comment
Contributor
There was a problem hiding this comment.
Thanks @theirix, I measured a 38% improvement in a micro benchmark!
Contributor
Author
Thank you for measuring this, it's a good result! |
Jefffrey
approved these changes
Jul 14, 2026
Contributor
|
thanks @theirix & @nuno-faria |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
date_partUDF optimisations #23351.Rationale for this change
Optimise
date_partto avoid extra operations duringisodow- Arrow'sDayOfWeekMonday1is now availableWhat changes are included in this PR?
Switch from manual dow calculation to a built-in
DayOfWeekMonday1Are these changes tested?
Are there any user-facing changes?